Removed arcs and arc_indexes in Fsa
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qindazhu
commented
Jul 2, 2020
|
Finally @danpovey I'm not quite sure about the interface I created in @csukuangfj I comment pybind build for now as it seems we need to re-create most of those bindings, we can fix them later. |
qindazhu
commented
Jul 3, 2020
qindazhu
changed the title
arcs and arc_indexes in Fsa
|
Looks good to me, from a quick look! Thanks! |
qindazhu
force-pushed
the
haowen-fsa
branch
2 times, most recently
from
7bc217e to
e7e1d64
Compare
|
+1 |
|
Merging.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore changes in Python folder, just comment to disable those tests for now, will update the py-bindings later.