make Fsa inherit from Array2 and add some operator overloads in Array2 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
qindazhu
changed the title
|
Fsa now inherits from Array2, I will replace Fsa with Array2 in those Fsa related algorithms one by one. @danpovey @csukuangfj Please have a look. |
|
LGTM, thanks! |
|
OK with me |
|
+1 |
|
Thanks! Merging.. |
csukuangfj
reviewed
Jul 12, 2020
| struct Fsa { | ||
| // TODO(haowen): finally we will remove `arc_indexes` and `arcs`, but for now, | ||
| // we would keep them to replace Fsa with Array2 incrementally. | ||
| struct Fsa : public Array2<Arc *, int32_t> { |
There was a problem hiding this comment.
Does this mean that the stride of the underlying memory is always 1 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.