implement MaxAuxLabels1(2)

[qindazhu]

Changes in dense_fsa.h and fsa.h are only for passing style check.

[danpovey]

Great! Sorry dont have time for detailed review...

[qindazhu]

OK, let's wait for @csukuangfj 's review.

[danpovey]

RE assumptions about epsilons etc.: make sure to document any assumptions. There may be certain situations where we will want to treat epsilons as normal symbols. Important thing now is to make sure everything is clearly documented.

…

On Mon, Jun 1, 2020 at 10:12 PM Haowen Qiu ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In k2/csrc/aux_labels.cc <https://github.com/danpovey/k2/pull/50#discussion_r433258554>: > +#include <numeric> +#include <vector> + +#include "glog/logging.h" +#include "k2/csrc/fsa.h" + +namespace k2 { + +void MapAuxLabels1(const AuxLabels &labels_in, + const std::vector<int32_t> &arc_map, AuxLabels *labels_out) { + CHECK_NOTNULL(labels_out); + auto &start_pos = labels_out->start_pos; + auto &labels = labels_out->labels; + start_pos.clear(); + labels.clear(); + will remove DCHECK_NE(label, kEpsilon) and use insert, I prefer to only reserve for start_pos here (we may always allocate too much memory (even if we resize at last) for most of FSA algorithms). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/danpovey/k2/pull/50#discussion_r433258554>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZFLO5GUUS44OKJWZQG2I3RUOZOFANCNFSM4NPXKR6Q> .

[qindazhu]

It is documented in .h file, @csukuangfj and I were talking about if we should check labels!=kEpsilon in the implementation (DCHECK).

[danpovey]

I may have changed my mind.. my feeling is if we can treat epsilon the same as other symbols, and document so, it would be OK. I have realized there are scenarios where epsilon is best treated as a normal symbol.

…

On Mon, Jun 1, 2020 at 10:24 PM Haowen Qiu ***@***.***> wrote: It is documented in .h file, @csukuangfj <https://github.com/csukuangfj> and I were talking about if we should check labels!=kEpsilon in the implementation (DCHECK). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/danpovey/k2/pull/50#issuecomment-636890432>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZFLO3R7PMRVDOQEOBFEUTRUO23JANCNFSM4NPXKR6Q> .

[qindazhu]

OK, I will remove the requirement (labels != kEpsilon) in .h file.

[qindazhu]

Ready to merge.

[csukuangfj]

+2

[csukuangfj]

Merging.