implement RmEpsilonPrunedLogSum #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qindazhu
commented
May 29, 2020
|
you can merge if you want |
|
Ok, merging. |
danpovey
reviewed
May 29, 2020
| b->arc_indexes.reserve(num_states_b + 1); | ||
| int32_t arc_num_b = 0; | ||
|
|
||
| const double *forward_state_weights = a.ForwardStateWeights(); |
There was a problem hiding this comment.
@qindazhu I notice that your code tends to be a bit unstructured and hard to read. Compare with my code in determinize.cc... see that I mostly have shorter functions and I spend a lot of time documenting things. Just think about it for the future.
There was a problem hiding this comment.
Sure, actually I plan to refactor the code after implemented RmEpsMax/LogSum(non pruned version, so there are 4 similar function). Of course, will notice the documentation issue. Thanks!
danpovey
reviewed
May 29, 2020
| @@ -50,6 +52,41 @@ inline int32_t InsertIntersectionState( | |||
| return result.first->second; | |||
| } | |||
|
|
|||
| static void TraceBackRmEpsilonLogSum( | |||
There was a problem hiding this comment.
Compare this with how carefully I document functions like this in determinize.cc.
There was a problem hiding this comment.
OK, will add in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.