implement RmEpsilonPruneMax

[qindazhu]

Input

Output

[qindazhu]

Will go back to this PR after compile determinize.cc. Just go over to validate the correctness of the whole algorthim, will add arc_map later.

[qindazhu]

Remapped state_id in output b, added arc_derivs

[qindazhu]

Sorry, forgot to remove WIP in the title. Ready to merge if there's no other issues.

[danpovey]

It's good that you implemented this, but this implementation would be too slow. Please look at the extended comment in the header where I declared this function.

[qindazhu]

@danpovey implemented with traceback-based algorithm, please have a review.

[danpovey]

OK, later.

…

On Mon, May 25, 2020 at 8:48 PM Haowen Qiu ***@***.***> wrote: @danpovey <https://github.com/danpovey> implemented with traceback-based algorithm, please have a review. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/danpovey/k2/pull/40#issuecomment-633555950>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZFLO7J3TVGZDEPP6ZXSLDRTJSKZANCNFSM4NAMG5DQ> .

[csukuangfj]

Looks good to me.

[danpovey]

Sorry I may have to look at this tomorrow.

…

On Mon, May 25, 2020 at 10:54 PM Fangjun Kuang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In k2/csrc/fsa_algo_test.cc <https://github.com/danpovey/k2/pull/40#discussion_r429975892>: > + delete log_wfsa_; + } + + WfsaWithFbWeights *max_wfsa_; + WfsaWithFbWeights *log_wfsa_; + Fsa *fsa_; + int32_t num_states_; + float *arc_weights_; +}; + +TEST_F(RmEpsilonTest, RmEpsilonsPrunedMax) { + Fsa b; + std::vector<std::vector<int32_t>> arc_derivs_b; + RmEpsilonsPrunedMax(*max_wfsa_, 8, &b, &arc_derivs_b); + + IsEpsilonFree(b); EXPECT_TRUE(IsEpsilonFree(b)); — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/danpovey/k2/pull/40#pullrequestreview-417761011>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZFLO2OH5GUHI6H3OGUY4TRTKBAZANCNFSM4NAMG5DQ> .

[danpovey]

Cool! Merging.