implement IsDeterministic and IsEpsilonFree, write tests

[qindazhu]

No description provided.

[danpovey]

Thanks! Lets not use braces where not necessary. I prefer code that's vertically fairly compact (perhaps because I tend to use a small screen...)

…

On Fri, Apr 24, 2020 at 12:48 PM Fangjun Kuang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In k2/csrc/properties_test.cc <danpovey#4 (comment)>: > fsa.arcs = arcs; - sorted = IsTopSorted(fsa); - EXPECT_TRUE(sorted); + bool hasSelfLoops = HasSelfLoops(fsa); The same for line 48. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <danpovey#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZFLO5Z5QRS4Q7MXBMQP4TROEKY5ANCNFSM4MPYW4XA> .

[danpovey]

variables should be like_this.

…

On Fri, Apr 24, 2020 at 12:48 PM Fangjun Kuang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In k2/csrc/properties_test.cc <danpovey#4 (comment)>: > fsa.arcs = arcs; - sorted = IsTopSorted(fsa); - EXPECT_TRUE(sorted); + bool hasSelfLoops = HasSelfLoops(fsa); + EXPECT_TRUE(hasSelfLoops); +} + +TEST(Properties, IsNotDeterministic) { + std::vector<Arc> arcs = {{0, 1, 2}, {1, 2, 0}, {1, 3, 0}, }; + std::vector<Range> leaving_arcs = {{0, 1}, {1, 3}, }; + Fsa fsa; + fsa.leaving_arcs = leaving_arcs; + fsa.arcs = arcs; + bool isDeterministic = IsDeterministic(fsa); the naming style for variables should be consistent. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <danpovey#4 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZFLO7IKKKPYFV5V4XQ7T3ROEK2RANCNFSM4MPYW4XA> .