implement randomPath #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qindazhu
force-pushed
the
haowen-fsa-equivalent
branch
from
c10d141 to
1e362c1
Compare
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
csukuangfj
reviewed
Apr 27, 2020
qindazhu
force-pushed
the
haowen-fsa-equivalent
branch
from
1e362c1 to
1e4efad
Compare
|
Ready to merge. |
|
Great! Thanks @csukuangfj for your very detailed comments! You guys can merge when you think it's ready. |
|
+2 |
|
@danpovey did you set a policy that one cannot merge his own PR? I cann not merge this by myself. Maybe you or @csukuangfj can help to merge it. |
|
I didn't set that, might be a default.
…On Tue, Apr 28, 2020 at 10:43 AM Haowen Qiu ***@***.***> wrote:
@danpovey <https://github.com/danpovey> did you set a policy that one
cannot merge his own PR? I cann not merge this by myself. Maybe you or
@csukuangfj <https://github.com/csukuangfj> can help to merge it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/danpovey/k2/pull/16#issuecomment-620343960>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZFLOZ22J5ZLIUN4M2HZZ3ROY7ELANCNFSM4MR2WOGQ>
.
|
csukuangfj
reviewed
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.