Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eval to internal/eval #1134

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Move eval to internal/eval #1134

merged 1 commit into from
Dec 25, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Dec 25, 2024

SSIA.

@k1LoW k1LoW self-assigned this Dec 25, 2024
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1134 (c93a73a) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,860,262,419 ns/op 3,645,056,209 ns/op -215,206,210 ns/op
Bytes allocated per iteration 1,383,627,624 B/op 1,383,413,912 B/op -213,712 B/op
Allocs per iteration 19,141,641 allocs/op 19,141,840 allocs/op 199 allocs/op
Metadata
main (-) #1134 (c93a73a)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1134 (c93a73a) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,766,440,099 ns/op 5,021,954,311 ns/op 255,514,212 ns/op
Bytes allocated per iteration 2,297,076,320 B/op 2,297,155,952 B/op 79,632 B/op
Allocs per iteration 31,629,482 allocs/op 31,626,528 allocs/op -2,954 allocs/op
Metadata
main (-) #1134 (c93a73a)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1134 (c93a73a) +/-
Number of iterations 22 22 0
Nanoseconds per iteration 45,613,981 ns/op 46,523,023 ns/op 909,042 ns/op
Bytes allocated per iteration 23,187,039 B/op 23,165,809 B/op -21,230 B/op
Allocs per iteration 184,829 allocs/op 184,805 allocs/op -24 allocs/op
Metadata
main (-) #1134 (c93a73a)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (85c668e) #1134 (c93a73a) +/-
Coverage 64.5% 64.3% -0.3%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 6m2s 5m54s -8s
Details
  |                     | main (85c668e) | #1134 (c93a73a) |  +/-  |
  |---------------------|----------------|-----------------|-------|
- | Coverage            |          64.5% |           64.3% | -0.3% |
  |   Files             |             77 |              78 |    +1 |
  |   Lines             |           8993 |            8999 |    +6 |
- |   Covered           |           5805 |            5788 |   -17 |
- | Code to Test Ratio  |          1:0.7 |           1:0.7 |  -0.1 |
  |   Code              |          16482 |           16505 |   +23 |
  |   Test              |          12621 |           12621 |     0 |
+ | Test Execution Time |           6m2s |           5m54s |   -8s |

Code coverage of files in pull request scope (0.0% → 67.3%)

Files Coverage +/-
alias.go 100.0% +100.0%
internal/eval/eval.go 65.9% +65.9%

Reported by octocov

@k1LoW k1LoW merged commit 8930f9e into main Dec 25, 2024
9 checks passed
@k1LoW k1LoW deleted the move-eval-internal branch December 25, 2024 07:36
@github-actions github-actions bot mentioned this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant