Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support steps[*].defer: steps.<key>.defer: for deferring steps in a runbook #1119

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Dec 17, 2024

Support defer: for deferring steps in a runbook.

@k1LoW k1LoW added enhancement New feature or request minor labels Dec 17, 2024
@k1LoW k1LoW self-assigned this Dec 17, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW requested a review from k2tzumi December 17, 2024 12:43
@k1LoW k1LoW marked this pull request as ready for review December 17, 2024 12:43

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW changed the title Support defer: for deferring steps in a runbook Support steps[*].defer: steps.<key>.defer: for deferring steps in a runbook Dec 18, 2024
@k1LoW k1LoW marked this pull request as draft December 18, 2024 04:37
k1LoW added a commit that referenced this pull request Dec 18, 2024
…o map.

This will allow for easier handling of defer.

ref: #1119

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW marked this pull request as ready for review December 19, 2024 00:38

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1119 (c15d75b) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,649,723,834 ns/op 3,666,577,067 ns/op 16,853,233 ns/op
Bytes allocated per iteration 1,382,016,856 B/op 1,382,780,400 B/op 763,544 B/op
Allocs per iteration 18,998,611 allocs/op 19,000,726 allocs/op 2,115 allocs/op
Metadata
main (-) #1119 (c15d75b)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1119 (c15d75b) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,071,139,633 ns/op 4,904,953,899 ns/op -166,185,734 ns/op
Bytes allocated per iteration 2,290,114,064 B/op 2,289,635,544 B/op -478,520 B/op
Allocs per iteration 31,559,087 allocs/op 31,562,032 allocs/op 2,945 allocs/op
Metadata
main (-) #1119 (c15d75b)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1119 (c15d75b) +/-
Number of iterations 22 22 0
Nanoseconds per iteration 46,740,542 ns/op 46,116,816 ns/op -623,726 ns/op
Bytes allocated per iteration 23,176,495 B/op 23,154,610 B/op -21,885 B/op
Allocs per iteration 183,428 allocs/op 183,412 allocs/op -16 allocs/op
Metadata
main (-) #1119 (c15d75b)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (e1b024f) #1119 (c15d75b) +/-
Coverage 64.5% 64.6% +0.0%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Test Execution Time 6m39s 6m11s -28s
Details
  |                     | main (e1b024f) | #1119 (c15d75b) |  +/-  |
  |---------------------|----------------|-----------------|-------|
+ | Coverage            |          64.5% |           64.6% | +0.0% |
  |   Files             |             77 |              77 |     0 |
  |   Lines             |           8958 |            9003 |   +45 |
+ |   Covered           |           5783 |            5821 |   +38 |
+ | Code to Test Ratio  |          1:0.7 |           1:0.7 |  +0.0 |
  |   Code              |          16403 |           16487 |   +84 |
+ |   Test              |          12498 |           12586 |   +88 |
+ | Test Execution Time |          6m39s |           6m11s |  -28s |

Code coverage of files in pull request scope (74.1% → 74.2%)

Files Coverage +/-
bind.go 82.2% +0.2%
cdp.go 76.8% 0.0%
db.go 76.2% 0.0%
dbg.go 4.4% -0.1%
dump.go 68.9% -0.7%
exec.go 73.1% 0.0%
grpc.go 77.4% 0.0%
http.go 78.0% 0.0%
include.go 90.6% +0.1%
operator.go 80.5% +0.3%
parse.go 74.1% 0.0%
runner_runner.go 63.6% 0.0%
ssh.go 66.1% 0.0%
step.go 91.3% 0.0%
test.go 93.1% +0.5%

Reported by octocov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant