Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in cdp.go #1112

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix race condition in cdp.go #1112

merged 1 commit into from
Dec 12, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Dec 12, 2024

@k1LoW k1LoW added the bug Something isn't working label Dec 12, 2024
@k1LoW k1LoW self-assigned this Dec 12, 2024
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1112 (69bb9b6) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,843,068,827 ns/op 3,605,409,646 ns/op -237,659,181 ns/op
Bytes allocated per iteration 1,379,933,904 B/op 1,380,005,232 B/op 71,328 B/op
Allocs per iteration 18,945,132 allocs/op 18,945,092 allocs/op -40 allocs/op
Metadata
main (-) #1112 (69bb9b6)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1112 (69bb9b6) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,718,377,198 ns/op 4,991,006,951 ns/op 272,629,753 ns/op
Bytes allocated per iteration 2,271,743,832 B/op 2,271,707,592 B/op -36,240 B/op
Allocs per iteration 31,394,319 allocs/op 31,395,566 allocs/op 1,247 allocs/op
Metadata
main (-) #1112 (69bb9b6)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1112 (69bb9b6) +/-
Number of iterations 24 25 1
Nanoseconds per iteration 45,641,317 ns/op 45,500,895 ns/op -140,422 ns/op
Bytes allocated per iteration 22,937,087 B/op 22,922,355 B/op -14,732 B/op
Allocs per iteration 182,481 allocs/op 182,467 allocs/op -14 allocs/op
Metadata
main (-) #1112 (69bb9b6)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (370f874) #1112 (69bb9b6) +/-
Coverage 64.4% 64.4% 0.0%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 6m4s 5m44s -20s
Details
  |                     | main (370f874) | #1112 (69bb9b6) | +/-  |
  |---------------------|----------------|-----------------|------|
  | Coverage            |          64.4% |           64.4% | 0.0% |
  |   Files             |             77 |              77 |    0 |
  |   Lines             |           8875 |            8875 |    0 |
  |   Covered           |           5719 |            5719 |    0 |
- | Code to Test Ratio  |          1:0.7 |           1:0.7 | -0.1 |
  |   Code              |          16296 |           16297 |   +1 |
  |   Test              |          12271 |           12271 |    0 |
+ | Test Execution Time |           6m4s |           5m44s | -20s |

Code coverage of files in pull request scope (76.8% → 76.8%)

Files Coverage +/-
cdp.go 76.8% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit 4bbdc93 into main Dec 12, 2024
9 checks passed
@k1LoW k1LoW deleted the fix-race branch December 12, 2024 22:40
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant