Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STDIN value is handled as runn.stdin, not as Runn ID(s). #1108

Merged
merged 1 commit into from
Dec 13, 2024
Merged

STDIN value is handled as runn.stdin, not as Runn ID(s). #1108

merged 1 commit into from
Dec 13, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Dec 12, 2024

There are several ways to handle Runn IDs, but there is no way to handle stdin, so change the specification this way.

  • Drop handling STDIN as Runn ID.
  • Handle STDIN as runn.stdin, which can be retrieved from store.

@k1LoW k1LoW self-assigned this Dec 12, 2024
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1108 (c2f0231) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,641,051,888 ns/op 3,479,315,022 ns/op -161,736,866 ns/op
Bytes allocated per iteration 1,318,820,568 B/op 1,318,586,272 B/op -234,296 B/op
Allocs per iteration 18,782,243 allocs/op 18,782,036 allocs/op -207 allocs/op
Metadata
main (-) #1108 (c2f0231)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1108 (c2f0231) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,681,043,065 ns/op 4,877,602,733 ns/op 196,559,668 ns/op
Bytes allocated per iteration 2,271,791,040 B/op 2,271,541,112 B/op -249,928 B/op
Allocs per iteration 31,401,295 allocs/op 31,400,233 allocs/op -1,062 allocs/op
Metadata
main (-) #1108 (c2f0231)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1108 (c2f0231) +/-
Number of iterations 26 25 -1
Nanoseconds per iteration 49,167,196 ns/op 44,902,276 ns/op -4,264,920 ns/op
Bytes allocated per iteration 20,811,182 B/op 20,802,435 B/op -8,747 B/op
Allocs per iteration 181,070 allocs/op 181,080 allocs/op 10 allocs/op
Metadata
main (-) #1108 (c2f0231)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (3c4a175) #1108 (c2f0231) +/-
Coverage 64.5% 64.5% +0.0%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 5m41s 6m9s +28s
Details
  |                     | main (3c4a175) | #1108 (c2f0231) |  +/-  |
  |---------------------|----------------|-----------------|-------|
+ | Coverage            |          64.5% |           64.5% | +0.0% |
  |   Files             |             77 |              77 |     0 |
  |   Lines             |           8878 |            8891 |   +13 |
+ |   Covered           |           5733 |            5743 |   +10 |
- | Code to Test Ratio  |          1:0.7 |           1:0.7 |  -0.1 |
  |   Code              |          16273 |           16297 |   +24 |
  |   Test              |          12271 |           12271 |     0 |
- | Test Execution Time |          5m41s |            6m9s |  +28s |

Code coverage of files in pull request scope (52.3% → 53.5%)

Files Coverage +/-
flags/flags.go 0.0% 0.0%
store.go 76.0% -1.3%

Reported by octocov

@k1LoW k1LoW added the minor label Dec 12, 2024
@k1LoW k1LoW changed the title STDIN value is handled as runn.stdin, not as Runn ID. STDIN value is handled as runn.stdin, not as Runn ID(s). Dec 12, 2024
@k1LoW k1LoW requested a review from k2tzumi December 12, 2024 14:03
@k1LoW k1LoW merged commit 2222408 into main Dec 13, 2024
9 checks passed
@k1LoW k1LoW deleted the stdin branch December 13, 2024 09:50
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant