Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition #1092

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Fix race condition #1092

merged 3 commits into from
Dec 4, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Dec 4, 2024

ref: #1091

I have added a global mutex in this PR and would like to remove it in the future.

@k1LoW k1LoW added the bug Something isn't working label Dec 4, 2024
@k1LoW k1LoW self-assigned this Dec 4, 2024

This comment has been minimized.

This comment has been minimized.

k1LoW added a commit to k1LoW/stopw that referenced this pull request Dec 4, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

BenchmarkManyRunbooks-4

main (-) #1092 (cbdb8b4) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,672,809,057 ns/op 3,437,094,600 ns/op -235,714,457 ns/op
Bytes allocated per iteration 1,318,815,096 B/op 1,318,865,568 B/op 50,472 B/op
Allocs per iteration 18,781,636 allocs/op 18,782,318 allocs/op 682 allocs/op
Metadata
main (-) #1092 (cbdb8b4)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1092 (cbdb8b4) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,652,323,024 ns/op 4,746,533,410 ns/op 94,210,386 ns/op
Bytes allocated per iteration 2,278,396,112 B/op 2,278,228,856 B/op -167,256 B/op
Allocs per iteration 31,456,338 allocs/op 31,457,028 allocs/op 690 allocs/op
Metadata
main (-) #1092 (cbdb8b4)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1092 (cbdb8b4) +/-
Number of iterations 25 26 1
Nanoseconds per iteration 44,877,953 ns/op 44,646,967 ns/op -230,986 ns/op
Bytes allocated per iteration 20,820,115 B/op 20,802,979 B/op -17,136 B/op
Allocs per iteration 181,085 allocs/op 181,074 allocs/op -11 allocs/op
Metadata
main (-) #1092 (cbdb8b4)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

@k1LoW k1LoW changed the title Add race test Fix race condition Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Code Metrics Report

main (bac268e) #1092 (cbdb8b4) +/-
Coverage 64.5% 64.5% -0.1%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 6m32s 4m38s -1m54s
Details
  |                     | main (bac268e) | #1092 (cbdb8b4) |  +/-   |
  |---------------------|----------------|-----------------|--------|
- | Coverage            |          64.5% |           64.5% |  -0.1% |
  |   Files             |             77 |              77 |      0 |
  |   Lines             |           8836 |            8843 |     +7 |
+ |   Covered           |           5703 |            5707 |     +4 |
- | Code to Test Ratio  |          1:0.7 |           1:0.7 |   -0.1 |
  |   Code              |          16200 |           16212 |    +12 |
  |   Test              |          12251 |           12251 |      0 |
+ | Test Execution Time |          6m32s |           4m38s | -1m54s |

Code coverage of files in pull request scope (71.8% → 71.7%)

Files Coverage +/-
dbg.go 4.5% +1.6%
eval.go 82.6% -0.5%
http_validator.go 81.1% -1.1%
operator.go 80.0% 0.0%

Reported by octocov

@k1LoW k1LoW marked this pull request as ready for review December 4, 2024 06:56
@k1LoW k1LoW merged commit 6023603 into main Dec 4, 2024
9 checks passed
@k1LoW k1LoW deleted the fix-race branch December 4, 2024 06:57
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant