-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow absolute paths and enhance scopes detection #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
k1LoW
changed the title
Allow absolute paths
Allow absolute paths and enhance scopes detection
Nov 26, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
BenchmarkManyRunbooks-4
Metadata
BenchmarkOpenAPI3-4
Metadata
BenchmarkSingleRunbook-4
Metadata
Reported by octocov |
Code Metrics Report
Details | | main (9990ad7) | #1080 (fe6b7da) | +/- |
|---------------------|----------------|-----------------|-------|
- | Coverage | 64.5% | 64.5% | -0.1% |
| Files | 77 | 77 | 0 |
| Lines | 8737 | 8832 | +95 |
+ | Covered | 5640 | 5697 | +57 |
+ | Code to Test Ratio | 1:0.7 | 1:0.7 | +0.0 |
| Code | 16069 | 16194 | +125 |
+ | Test | 12014 | 12133 | +119 |
- | Test Execution Time | 5m54s | 6m2s | +8s | Code coverage of files in pull request scope (73.8% → 73.4%)
Reported by octocov |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1073
Enhanced scope determination for file paths containing runbooks.
In addition, absolute paths are now allowed everywhere.
It's a bug that in some sections it was reading files in directories higher than the runbook even though there was no
read:parent
scope.