Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor store ( Start adding secrets: sections ) #1074

Merged
merged 9 commits into from
Nov 17, 2024
Merged

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Nov 16, 2024

ref: #986

@k1LoW k1LoW self-assigned this Nov 16, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW changed the title Refactor store Refactor store ( Start adding secrets: sections ) Nov 16, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW marked this pull request as draft November 16, 2024 10:51

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW marked this pull request as ready for review November 17, 2024 04:38

This comment has been minimized.

Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #1074 (bfb3216) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,481,122,569 ns/op 3,684,371,137 ns/op 203,248,568 ns/op
Bytes allocated per iteration 1,350,190,840 B/op 1,350,438,704 B/op 247,864 B/op
Allocs per iteration 18,946,774 allocs/op 18,958,798 allocs/op 12,024 allocs/op
Metadata
main (-) #1074 (bfb3216)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #1074 (bfb3216) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,740,033,834 ns/op 4,674,960,646 ns/op -65,073,188 ns/op
Bytes allocated per iteration 2,265,424,904 B/op 2,265,584,832 B/op 159,928 B/op
Allocs per iteration 31,313,692 allocs/op 31,315,880 allocs/op 2,188 allocs/op
Metadata
main (-) #1074 (bfb3216)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #1074 (bfb3216) +/-
Number of iterations 24 25 1
Nanoseconds per iteration 45,803,486 ns/op 45,504,899 ns/op -298,587 ns/op
Bytes allocated per iteration 22,389,461 B/op 22,414,004 B/op 24,543 B/op
Allocs per iteration 184,052 allocs/op 184,170 allocs/op 118 allocs/op
Metadata
main (-) #1074 (bfb3216)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (10bfec2) #1074 (bfb3216) +/-
Coverage 64.5% 64.4% -0.1%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 5m49s 4m15s -1m34s
Details
  |                     | main (10bfec2) | #1074 (bfb3216) |  +/-   |
  |---------------------|----------------|-----------------|--------|
- | Coverage            |          64.5% |           64.4% |  -0.1% |
  |   Files             |             77 |              77 |      0 |
  |   Lines             |           8710 |            8704 |     -6 |
- |   Covered           |           5619 |            5611 |     -8 |
- | Code to Test Ratio  |          1:0.7 |           1:0.7 |   -0.1 |
  |   Code              |          16006 |           16012 |     +6 |
+ |   Test              |          11729 |           11733 |     +4 |
+ | Test Execution Time |          5m49s |           4m15s | -1m34s |

Code coverage of files in pull request scope (75.1% → 74.9%)

Files Coverage +/-
book.go 79.0% 0.0%
dbg.go 2.9% 0.0%
http.go 78.1% 0.0%
include.go 91.1% 0.0%
operator.go 80.1% -0.3%
runbook.go 81.3% +0.1%
store.go 76.5% -0.4%

Reported by octocov

@k1LoW k1LoW merged commit 6b8b76f into main Nov 17, 2024
8 checks passed
@k1LoW k1LoW deleted the refactor-store branch November 17, 2024 04:59
@github-actions github-actions bot mentioned this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant