Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support if: section for three metrics #279

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Support if: section for three metrics #279

merged 2 commits into from
Sep 30, 2023

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Sep 30, 2023

No description provided.

@k1LoW k1LoW added the enhancement New feature or request label Sep 30, 2023
@k1LoW k1LoW self-assigned this Sep 30, 2023
@k1LoW k1LoW changed the title Support if: section for three metrics Support if: section for three metrics Sep 30, 2023
Base automatically changed from remove-title to main September 30, 2023 09:19
@github-actions

This comment has been minimized.

@k1LoW k1LoW merged commit bc1f797 into main Sep 30, 2023
5 checks passed
@k1LoW k1LoW deleted the metrics-if branch September 30, 2023 09:24
@github-actions github-actions bot mentioned this pull request Sep 30, 2023
@github-actions
Copy link
Contributor

Code Metrics Report

main (3b418fd) #279 (a9e0686) +/-
Coverage 66.4% 66.4% +0.0%
Code to Test Ratio 1:0.5 1:0.5 -0.0
Test Execution Time 36s 15s -21s
Details
  |                     | main (3b418fd) | #279 (a9e0686) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          66.4% |          66.4% | +0.0% |
  |   Files             |             31 |             31 |     0 |
  |   Lines             |           2784 |           2799 |   +15 |
+ |   Covered           |           1849 |           1859 |   +10 |
- | Code to Test Ratio  |          1:0.5 |          1:0.5 |  -0.0 |
  |   Code              |           7196 |           7220 |   +24 |
  |   Test              |           3642 |           3642 |     0 |
+ | Test Execution Time |            36s |            15s |  -21s |

Code coverage of files in pull request scope (59.7% → 60.0%)

Files Coverage +/-
config/config.go 59.8% +0.6%
config/ready.go 60.2% -0.0%

Benchmark-0 (this is custom metrics test)

main (3b418fd) #279 (a9e0686) +/-
Number of iterations 1000 1000 0
Nanoseconds per iteration 676.5 ns/op 676.5 ns/op 0.0 ns/op
Metadata
main (3b418fd) #279 (a9e0686)
goos darwin darwin
goarch amd64 amd64

Benchmark-1 (this is custom metrics test)

main (3b418fd) #279 (a9e0686) +/-
Number of iterations 1500 1500 0
Nanoseconds per iteration 1345 ns/op 1345 ns/op 0 ns/op
Metadata
main (3b418fd) #279 (a9e0686)
goos darwin darwin
goarch amd64 amd64

Reported by octocov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant