Skip to content

Commit

Permalink
Remove unnecessary nil checks
Browse files Browse the repository at this point in the history
  • Loading branch information
k2tzumi committed Jan 21, 2024
1 parent 6c79005 commit 7844b9f
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,31 +201,23 @@ type Reporter interface {
func (c *Config) Acceptable(r, rPrev Reporter) error {
var result *multierror.Error
if err := c.CoverageConfigReady(); err == nil {
prev := 0.0
if rPrev != nil {
prev = rPrev.CoveragePercent()
}
prev := rPrev.CoveragePercent()
if err := coverageAcceptable(r.CoveragePercent(), prev, c.Coverage.Acceptable); err != nil {
result = multierror.Append(result, err)
}
}

if err := c.CodeToTestRatioConfigReady(); err == nil {
prev := 0.0
if rPrev != nil {
prev = rPrev.CodeToTestRatioRatio()
}
prev := rPrev.CodeToTestRatioRatio()
if err := codeToTestRatioAcceptable(r.CodeToTestRatioRatio(), prev, c.CodeToTestRatio.Acceptable); err != nil {
result = multierror.Append(result, err)
}
}

if err := c.TestExecutionTimeConfigReady(); err == nil {
prev := largeEnoughTime
if rPrev != nil {
if rPrev.IsMeasuredTestExecutionTime() {
prev = rPrev.TestExecutionTimeNano()
}
if rPrev.IsMeasuredTestExecutionTime() {
prev = rPrev.TestExecutionTimeNano()
}

if err := testExecutionTimeAcceptable(r.TestExecutionTimeNano(), prev, c.TestExecutionTime.Acceptable); err != nil {
Expand Down

0 comments on commit 7844b9f

Please sign in to comment.