Support bash like interpolate #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k2tzumi
commented
Jul 16, 2022
| @@ -14,7 +14,7 @@ lint: | |||
| depsdev: | |||
| go install github.com/Songmu/ghch/cmd/[email protected] | |||
| go install github.com/Songmu/gocredits/cmd/[email protected] | |||
| go install github.com/securego/gosec/v2/cmd/gosec@v2.8.1 | |||
| go install github.com/securego/gosec/v2/cmd/gosec@v2.11.0 | |||
There was a problem hiding this comment.
CI failed, so I fixed it with the following
securego/gosec#797
|
@k2tzumi GREAT!!! THANK YOU!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
I want to be able to specify default values when expanding environment variables.
If
UNDEFINED_VARis unset or NULL,defaultis expanded; otherwise, the value ofUNDEFINED_VARis assigned.Contents of Proposal
Delegate processing from
os.Expandtogithub.aaakk.us.kg/buildkite/interpolate.