Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transit gateway type #517

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Conversation

odg0318
Copy link
Contributor

@odg0318 odg0318 commented Jun 28, 2020

I added transit gateway type.

Related to #470

@k1LoW
Copy link
Owner

k1LoW commented Jun 28, 2020

Hi @odg0318 !!! GREAT !!! Thank you !!

@k1LoW k1LoW merged commit b58f1e9 into k1LoW:master Jun 28, 2020
@k1LoW
Copy link
Owner

k1LoW commented Jun 28, 2020

Released as v1.20.0.

### exist

```ruby
describe tgw('tgw-1234567890abcdefg') do
Copy link
Contributor Author

@odg0318 odg0318 Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k1LoW I found my mistake here.

describe transit_gateway('tgw-1234567890abcdefg') do

I am not sure how to fix this mistake. You have already merged this PR.
Can I create new PR to fix?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I'll fix it !! Thanks !

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed !

k1LoW added a commit that referenced this pull request Jun 29, 2020
@k1LoW
Copy link
Owner

k1LoW commented Jul 4, 2020

Released as v1.21.0.

@odg0318 odg0318 deleted the add-type-transitgateway branch August 2, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants