Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint to v1.55.2 #3755

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Nov 24, 2023

Description

Adapt to updated linters:

  • Update configuration
  • Silence some opinionated new warnings

https://github.com/golangci/golangci-lint/releases/tag/v1.52.0
https://github.com/golangci/golangci-lint/releases/tag/v1.52.1
https://github.com/golangci/golangci-lint/releases/tag/v1.52.2
https://github.com/golangci/golangci-lint/releases/tag/v1.53.0
https://github.com/golangci/golangci-lint/releases/tag/v1.53.1
https://github.com/golangci/golangci-lint/releases/tag/v1.53.2
https://github.com/golangci/golangci-lint/releases/tag/v1.53.3
https://github.com/golangci/golangci-lint/releases/tag/v1.54.0
https://github.com/golangci/golangci-lint/releases/tag/v1.54.1
https://github.com/golangci/golangci-lint/releases/tag/v1.54.2
https://github.com/golangci/golangci-lint/releases/tag/v1.55.0
https://github.com/golangci/golangci-lint/releases/tag/v1.55.1
https://github.com/golangci/golangci-lint/releases/tag/v1.55.2

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 requested a review from a team as a code owner November 24, 2023 11:07
@twz123
Copy link
Member Author

twz123 commented Nov 24, 2023

Okay, this need more attention.

@twz123 twz123 marked this pull request as draft November 24, 2023 11:12
@twz123 twz123 force-pushed the bump-golangci-lint branch from 0a92ece to 0873cfe Compare November 27, 2023 08:30
@twz123 twz123 marked this pull request as ready for review November 27, 2023 14:58
@twz123 twz123 merged commit 20b7986 into k0sproject:main Nov 28, 2023
@twz123 twz123 deleted the bump-golangci-lint branch November 28, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants