Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream validation logic for kubelet serving CSRs #3001

Conversation

jnummelin
Copy link
Member

Description

This way we'll be in sync with all rules relating RSA etc. key usages.

kubernetes/kubernetes#111660

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jnummelin jnummelin requested a review from a team as a code owner April 14, 2023 12:04
@jnummelin jnummelin requested review from makhov and twz123 April 14, 2023 12:04
@jnummelin jnummelin mentioned this pull request Apr 14, 2023
11 tasks
This way we'll be in sync with all rules relating RSA etc. key usages.

kubernetes/kubernetes#111660

Signed-off-by: Jussi Nummelin <[email protected]>
@jnummelin jnummelin force-pushed the csp-approver/ensure-proper-usages-with-rsa branch from 2007b92 to d51a2e1 Compare April 14, 2023 12:14
@jnummelin jnummelin merged commit f676c8a into k0sproject:main Apr 14, 2023
@jnummelin jnummelin deleted the csp-approver/ensure-proper-usages-with-rsa branch April 14, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants