Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent leaking global flags from dependencies #2948

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Mar 30, 2023

Description

It may happen that dependencies used by k0s will add their own global flags, which then end up in k0s's flags. Add a unit test that verifies that no unwanted flags are leaking. Move the workarounds for hiding unavoidable flags into the appropriate places. The kubectl code wasn't responsible for those, but the k0s cloud provider code was.

See also:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

It may happen that dependencies used by k0s will add their own global
flags, which then end up in k0s's flags. Add a unit test that verifies
that no unwanted flags are leaking. Move the workarounds for hiding
unavoidable flags into the appropriate places. The kubectl code wasn't
responsible for those, but the k0s cloud provider code was.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 requested a review from a team as a code owner March 30, 2023 14:13
@twz123 twz123 requested review from kke and jnummelin March 30, 2023 14:13
@twz123 twz123 merged commit 13ff7a8 into k0sproject:main Mar 31, 2023
@twz123 twz123 deleted the prevent-leaking-global-flags branch April 11, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants