Prevent leaking global flags from dependencies #2948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It may happen that dependencies used by k0s will add their own global flags, which then end up in k0s's flags. Add a unit test that verifies that no unwanted flags are leaking. Move the workarounds for hiding unavoidable flags into the appropriate places. The kubectl code wasn't responsible for those, but the k0s cloud provider code was.
See also:
Type of change
How Has This Been Tested?
Checklist: