Better error reporting in CSRApprover #2915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This has been done to ease debugging integration test failures when upgrading to Kubernetes 1.27 (#2879):
Refactor the CSRApprover component in a way that errors are reported in a more structured and detailed way. Let all bool functions return errors instead, so that they can explain what was rejected. Improve the logging of those errors, so that they aren't logged twice and the CSR names are included in the logs. Remove the csrRecognizer on the way, as there is only a single one, and there's no additional ones on the horizon, so this seemed unnecessary, and inlining it makes the approval loop easier to read.
Type of change
How Has This Been Tested?
Checklist: