Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly forward CGO settings into Kubernetes build #2910

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Properly forward CGO settings into Kubernetes build #2910

merged 1 commit into from
Mar 28, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Mar 23, 2023

Description

KUBE_STATIC_OVERRIDES is the proper counterpart to KUBE_CGO_OVERRIDES. Without setting it, some binaries might not be statically linked. This has been observed with kubelet in v1.27.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Properly forward CGO settings into Kubernetes build
38b57a6 
KUBE_STATIC_OVERRIDES is the proper counterpart to KUBE_CGO_OVERRIDES.
Without setting it, some binaries might not be statically linked.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 requested a review from a team as a code owner March 23, 2023 13:48
@twz123 twz123 mentioned this pull request Mar 23, 2023
Closed
11 tasks
@twz123 twz123 merged commit ac1c22b into k0sproject:main Mar 28, 2023
@twz123 twz123 deleted the static-kubernetes-binaries branch April 11, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @jnummelin