Use named return values in WriteAtomically #2235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The intention was to use a named return value, so that the deferred function would be able to modify it. Without the named value, the error handling in the deferred function has no effect.
Moreover: Add a bunch of tests and suppress any errors about failed removals of temporary files indicating that the files don't exist.
Fixes #1816.
The tests should've been added in the first PR already, but sometimes we can't help being a little sloppy 🙈
Type of change
How Has This Been Tested?
Checklist: