Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version from 4.0.2 to 4.0.3 #6

Merged
merged 3 commits into from
Jul 11, 2020

Conversation

NitinBhasneria
Copy link

@NitinBhasneria NitinBhasneria commented Jun 27, 2020

Bug Fix in #3 and #2.

@NitinBhasneria NitinBhasneria changed the title Bump version from 4.0.2 to 4.0.3 Bump version from 4.0.2 to 4.0.4 Jun 27, 2020
@NitinBhasneria NitinBhasneria changed the title Bump version from 4.0.2 to 4.0.4 Bump version from 4.0.2 to 4.0.3 Jun 27, 2020
@jywarren
Copy link
Owner

jywarren commented Jul 7, 2020

Oh awesome! I guess i would like to see if we could merge the in-progress Jest work from #7 first, and then write a couple simple Jest tests to demonstrate that those two bugs are resolved. What do you think?

@NitinBhasneria
Copy link
Author

Oh awesome! I guess i would like to see if we could merge the in-progress Jest work from #7 first, and then write a couple simple Jest tests to demonstrate that those two bugs are resolved. What do you think?

Ok, So just to be clear I have to write the test for #3 and #2. ??

@NitinBhasneria
Copy link
Author

NitinBhasneria commented Jul 10, 2020

Also, I am little confused about, this PR should be opened to branch master or branch plots2.
If we have to make it to master then can you please if the conflicts. Thanks.

@jywarren
Copy link
Owner

Hi, yes, this should be on plots2 branch, which I've made the default. Sorry, just so we preserve a master branch from the upstream bevacqua fork, in case we need to do rebasing, it's good to have a copy. Cool! And, yes, please, if you could add some simple tests for #3 and #2 that would be great!

@NitinBhasneria NitinBhasneria changed the base branch from master to plots2 July 10, 2020 16:14
@jywarren jywarren merged commit cf059e7 into jywarren:plots2 Jul 11, 2020
@jywarren
Copy link
Owner

Awesome! Now I need to publish this on npm. Will do soon!

@jywarren
Copy link
Owner

Oh actually we wouldn't be able to use the woofmark namespace as bevacqua already publishes this. Can you open a PR on the editor to repoint it at the GitHub address for jywarren/woofmark#plots2 using v4.0.3? I think there should be examples in there already for how to point at a GitHub url.

Thanks! If u have trouble ping me!!

@NitinBhasneria
Copy link
Author

Ok, will do it soon. Should we add #3 and #2 in publiclab/PublicLab.Editor#555.

@NitinBhasneria
Copy link
Author

@jywarren I will write the test after setting up jest test in #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants