Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue with Authenticated Proxies in Scrapy #17

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

dream2333
Copy link
Contributor

@dream2333 dream2333 commented Aug 7, 2024

This pull request addresses an issue in Scrapy where authenticated proxies fail to connect.

Scrapy's proxy middleware automatically processes the HTTP Proxy-Authorization header, which needs special handling for authenticated proxies. To resolve this, special handling for authenticated proxies has been implemented, ensuring that the Proxy-Authorization header is correctly set in the request headers. The changes include:


  1. Added logic to handle curl option and Proxy-Authorization in the handler.py file.
  2. Ensured that the Proxy-Authorization header is properly set for proxy requests requiring user authentication.

These changes will fix the connection issues with authenticated proxies

@jxlil
Copy link
Owner

jxlil commented Aug 8, 2024

Thanks!

@jxlil jxlil merged commit 8f89f1f into jxlil:master Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants