Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: uninstall danger.js and remove from dependencies (Issue #493) #527

Merged

Conversation

Jimmy-Vu
Copy link
Contributor

Description

The danger.js package is uninstalled (using npm uninstall --save-dev danger) from the project along with its related config files. .travis.yml is deleted following guidance in the issue discussion.

Fixes #493

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have read the CONTRIBUTING document.
  • My commits follow the commitizen commit convention
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Jimmy-Vu
Copy link
Contributor Author

There seems to be a problem with the lint checks (from the lint.yml file) for when I make a pull request from the Jimmy-Vu:CIO-493-uninstall-danger branch in my forked repo into the typescript-migration branch of this upstream repo. It doesn't think that my branch exist.

Error from the prettier lint check:

Determining the checkout info
  /usr/bin/git branch --list --remote origin/CIO-493-uninstall-danger
  /usr/bin/git tag --list CIO-493-uninstall-danger
  Error: A branch or tag with the name 'CIO-493-uninstall-danger' could not be found

I found this potential fix in this comment in an issue that seems to relate closely to what's occurring here. Could be worth a look.

@jwu910
Copy link
Owner

jwu910 commented Feb 25, 2023

oooh thanks, i'll try to take a look when I can and get the required changes into my branch

Copy link
Owner

@jwu910 jwu910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Jimmy-Vu my bad for not getting back to this sooner.

Can you take a look at the failing checks before we move forward?

Edit: This actually might be a faulty workflow file on my end... I dont think i've had any pull requests since i had merged the new workflow in myself

@Jimmy-Vu
Copy link
Contributor Author

Hey @jwu910, thanks for the heads up. Just to confirm I understand your edit message, is there something left to do on my end for this issue or is it just waiting for the workflow file to be fixed?

@jwu910
Copy link
Owner

jwu910 commented May 30, 2023

I gotta take a look at the workflow first, once I can debug that we'll be able to see how the checks resolve

@jwu910 jwu910 force-pushed the CIO-493-uninstall-danger branch from 902b4ad to ff4bc8e Compare June 10, 2023 23:18
The danger.js package is uninstalled from the project along with its
related config files. .travis.yml is deleted.

BREAKING CHANGE: 🧨 N/A

✅ Closes: 493
@jwu910 jwu910 force-pushed the CIO-493-uninstall-danger branch from ff4bc8e to 207ae2f Compare June 10, 2023 23:20
@jwu910 jwu910 merged commit e17f4da into jwu910:typescript-migration Jun 11, 2023
@jwu910 jwu910 linked an issue Jun 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninstall Danger.js
2 participants