Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(e2e): e2e-report #87

Merged
merged 2 commits into from
Jun 30, 2022
Merged

refactor(e2e): e2e-report #87

merged 2 commits into from
Jun 30, 2022

Conversation

AntonLantukh
Copy link
Collaborator

@AntonLantukh AntonLantukh commented Jun 16, 2022 •
edited
Loading

Description

  • Fixed types in e2e tests (now strict types are used in each test file)
  • Fixed tests
  • Workers added for CodeceptJS to run tests faster (~6 min for each device now)
  • Node version updated
  • Added allure report
  • Added artifacts for allure reports
  • File structure changed to support several features for one suite
  • Readme added

Steps completed:

According to our definition of done, I have completed the following steps:

  • User stories met
  • Storybook stories
  • Unit tests added
  • Linting passing
  • Unit tests passing
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@AntonLantukh AntonLantukh force-pushed the e2e/report-generation branch from 7ce9a5b to a39503a Compare June 16, 2022 13:19
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 16, 2022
View reviewed changes
test-e2e/utils/steps_file.ts
if (context) {
this.login({ email: context.email, password: context.password });
} else {
context = { email: passwordUtils.createRandomEmail(), password: passwordUtils.createRandomPassword() };

Check failure

Code scanning / CodeQL

Insecure randomness

Cryptographically insecure [random value](1) in a security context.
@AntonLantukh AntonLantukh force-pushed the e2e/report-generation branch 23 times, most recently from 6fdd31e to 0270e5b Compare June 22, 2022 20:44
refactor(e2e): e2e-report
0f3bae0 
- fixed types in e2e tests
- fixed failing e2e tests
- added allure report
- added artifact for allure
- node version updated
- tests folder refactoring
- retries added
@AntonLantukh AntonLantukh force-pushed the e2e/report-generation branch from 0270e5b to 0f3bae0 Compare June 22, 2022 22:12
@AntonLantukh AntonLantukh requested a review from dbudzins June 22, 2022 22:22
@AntonLantukh AntonLantukh marked this pull request as ready for review June 22, 2022 22:22
dbudzins
dbudzins reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@dbudzins dbudzins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good improvements and documentation. My only feedback is maybe consider not adding all the single file sub-folders in /test-e2e/test.

Also would it be good to just run lint fix on all of the files so we stop getting so many format change noise?

test-e2e/tests/account/index_test.ts Outdated Show resolved Hide resolved
@AntonLantukh
Copy link
Collaborator Author

Really good improvements and documentation. My only feedback is maybe consider not adding all the single file sub-folders in /test-e2e/test.

Also would it be good to just run lint fix on all of the files so we stop getting so many format change noise?

No problem. I think I should better merge linting changes first and then just update this branch.

@AntonLantukh AntonLantukh force-pushed the e2e/report-generation branch from 2fd42b6 to 1d5c940 Compare June 30, 2022 12:12
@AntonLantukh AntonLantukh force-pushed the e2e/report-generation branch from 1d5c940 to 596ad34 Compare June 30, 2022 12:54
@AntonLantukh AntonLantukh requested a review from dbudzins June 30, 2022 13:04
@AntonLantukh AntonLantukh merged commit a4c32cd into develop Jun 30, 2022
@AntonLantukh AntonLantukh linked an issue Jul 8, 2022 that may be closed by this pull request
Fix e2e test #79
Closed
@dbudzins dbudzins deleted the e2e/report-generation branch November 10, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbudzins dbudzins dbudzins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix e2e test
2 participants
@AntonLantukh @dbudzins