fix(series): add season prefix to episodes dropdown

jwplayer · Jun 23, 2021 · 3a89e3d · 3a89e3d
1 parent fed2e3b
commit 3a89e3d
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 2 deletions.
diff --git a/.commitlintrc.js b/.commitlintrc.js
@@ -7,6 +7,7 @@ module.exports = {
         'home',
         'playlist',
         'videodetail',
+        'series',
         'search',
         'watchhistory',
         'favorites',

diff --git a/README.md b/README.md
@@ -66,6 +66,7 @@ The allowed scopes are:
 - home
 - playlist
 - videodetail
+- series
 - search
 - watchhistory
 - favorites

diff --git a/src/components/Dropdown/Dropdown.tsx b/src/components/Dropdown/Dropdown.tsx
@@ -9,6 +9,7 @@ type Props = {
   defaultLabel: string;
   options: string[];
   optionsStyle?: string;
+  valuePrefix?: string;
   onChange: (event: React.ChangeEvent<HTMLSelectElement>) => void;
 };
 
@@ -19,6 +20,7 @@ const Dropdown: React.FC<Props & React.AriaAttributes> = ({
   options,
   onChange,
   optionsStyle,
+  valuePrefix,
   ...rest
 }: Props & React.AriaAttributes) => {
   return (
@@ -29,6 +31,7 @@ const Dropdown: React.FC<Props & React.AriaAttributes> = ({
         </option>
         {options.map((option) => (
           <option className={classNames(styles.option, optionsStyle)} key={option} value={option}>
+            {valuePrefix}
             {option}
           </option>
         ))}

diff --git a/src/components/Filter/Filter.tsx b/src/components/Filter/Filter.tsx
@@ -46,6 +46,7 @@ const Filter: FC<Props> = ({ name, value, defaultLabel, options, setValue, value
         <Dropdown
           options={options}
           defaultLabel={defaultLabel}
+          valuePrefix={valuePrefix}
           name={name}
           value={value}
           onChange={handleChange}

diff --git a/src/i18n/locales/en_US/video.json b/src/i18n/locales/en_US/video.json
@@ -1,11 +1,13 @@
 {
   "add_to_favorites": "Add to favorites",
+  "all_seasons": "All seasons",
   "copied_url": "Copied url",
   "current_episode": "Current episode",
   "currently_playing": "Currently playing",
   "episodes": "Episodes",
   "favorite": "Favorite",
   "remove_from_favorites": "Remove from favorites",
+  "season_prefix": "Season ",
   "share": "Share",
   "start_watching": "Start watching",
   "trailer": "Trailer",

diff --git a/src/i18n/locales/nl_NL/video.json b/src/i18n/locales/nl_NL/video.json
@@ -1,11 +1,13 @@
 {
   "add_to_favorites": "",
+  "all_seasons": "",
   "copied_url": "",
   "current_episode": "",
   "currently_playing": "",
   "episodes": "",
   "favorite": "",
   "remove_from_favorites": "",
+  "season_prefix": "",
   "share": "",
   "start_watching": "",
   "trailer": "",

diff --git a/src/screens/Series/Series.tsx b/src/screens/Series/Series.tsx
@@ -162,8 +162,8 @@ const Series = ({
               <Filter
                 name="categories"
                 value={seasonFilter}
-                valuePrefix="Season "
-                defaultLabel="All"
+                valuePrefix={t('season_prefix')}
+                defaultLabel={t('all_seasons')}
                 options={filters}
                 setValue={setSeasonFilter}
               />