Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add playerInModal to type def for JwConfig #83

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add playerInModal to type def for JwConfig #83

merged 1 commit into from
Sep 25, 2024

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Add typedef for a few non parsing props in JwConfig

Why is this Pull Request needed?

  • Missing typedefs

Are there any points in the code the reviewer needs to double check?

  • No

Are there any Pull Requests open in other repos which need to be merged with this?

  • No

Addresses Issue(s):

GitHub Issue

@Jmilham21 Jmilham21 requested a review from a team as a code owner September 10, 2024 17:09
@Jmilham21 Jmilham21 merged commit 184b04d into master Sep 25, 2024
@Jmilham21 Jmilham21 deleted the fix/issue-52-typedefs branch September 25, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-almaguer david-almaguer david-almaguer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jmilham21 @david-almaguer