Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fullscreen implementation for modals fix #58

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Opens interface option for specifying player in a modal for Android
  • Fixes UI hiccup for standard fullscreen Android where view would be skewed

Why is this Pull Request needed?

  • Fatal bug when using player in Modal

Are there any points in the code the reviewer needs to double check?

  • Does iOS need any help here?

Are there any Pull Requests open in other repos which need to be merged with this?

  • no

Addresses Issue(s):

GitHub Issue

@Jmilham21 Jmilham21 requested a review from a team as a code owner July 15, 2024 23:09
@Jmilham21 Jmilham21 merged commit fb8cd30 into master Aug 6, 2024
@Jmilham21 Jmilham21 deleted the fix/fullscreen-implementation-for-modals-fix branch August 6, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants