-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate SSR #595
Open
justuswilhelm
wants to merge
25
commits into
main
Choose a base branch
from
justus/2024-10-28-ssr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Activate SSR #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This minimizes the size of the HTML rendered
We want to avoid logging PII server-side
Combine with proxy, allow for requests to SSR backend to be transparently forwarded to backend. Must specify API_ENDPOINT_REWRITE_TO env var. Since we don't evaluate ws in SSR, there is no equivalent VITE_WS_ENDPOINT_REWRITE_TO env var.
justuswilhelm
force-pushed
the
justus/2024-10-28-ssr
branch
from
November 11, 2024 02:54
d213587
to
59164f5
Compare
justuswilhelm
force-pushed
the
justus/2024-10-28-ssr
branch
from
November 25, 2024 04:28
f5ad636
to
023f06b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.