Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with dplyr 1.1.0 #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lionel-
Copy link

@lionel- lionel- commented Dec 12, 2022

Hello, this PR fixes:

  • Warnings related to the tidyselect syntax. We now require all_of() for selecting with a vector of strings. Also we no longer support .data in selection contexts, instead use the simpler syntax of quoted column names with "".

  • Errors caused by a stricter dplyr::first() behaviour with defaults. The default must now be compatible with the input vector for reasons of type stability.

We plan to release dplyr on January 27. The fixes in this PR are compatible with both CRAN and dev dplyr, so it'd be helpful if you could send a preemptive release to CRAN.

Use `all_of()`. Silences warnings like:

```
Using an external vector in selections was deprecated in tidyselect 1.1.0.
ℹ Please use `all_of()` or `any_of()` instead.
  # Was:
  data %>% select(list.censor)

  # Now:
  data %>% select(all_of(list.censor))
```

Quote variable names as "foo" instead of using `.data$foo`.
Silences warnings like:

```
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"val"` instead of `.data$val`
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant