Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump duckdb to 0.10.3 #47

Closed
wants to merge 1 commit into from

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Jul 12, 2024

Problem

The target should probably support this before 1.0.0.

Proposed changes

Just bump to the next patch version.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 12, 2024 20:15
@jwills
Copy link
Owner

jwills commented Jul 12, 2024

Ah we had some issues with 0.10.3 in dbt-duckdb, I wasn't sure we were going to support it here

@guenp
Copy link
Collaborator

guenp commented Jul 24, 2024

Going to open a new PR to bump to 1.0.0. We needed to skip 0.10.3 unfortunately (see PR). Thanks @edgarrmondragon !

@guenp guenp closed this Jul 24, 2024
@edgarrmondragon edgarrmondragon deleted the duckdb-0.10.3 branch July 24, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants