Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #36 #37

Merged
merged 3 commits into from
May 3, 2024
Merged

Fix issue #36 #37

merged 3 commits into from
May 3, 2024

Conversation

jwills
Copy link
Owner

@jwills jwills commented May 2, 2024

Problem

We have a bug where the update operation fails on ingest when all of the columns are primary keys.

Proposed changes

If all of the columns in a table are primary keys, skip the UPDATE operation-- there's nothing for us to do there.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@jwills
Copy link
Owner Author

jwills commented May 2, 2024

Fixes #36

@jwills
Copy link
Owner Author

jwills commented May 2, 2024

This is failing for MD reasons; will run a test with it against 0.9.2 and ensure it works there

@jwills jwills merged commit 86fec06 into main May 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant