Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quotes for database and schema name #33

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

JichaoS
Copy link
Contributor

@JichaoS JichaoS commented Feb 1, 2024

Without quotes, duckdb complains about table creation for database/schema names starting with a number. Say an uuid.

Problem

For a database named "1.duckdb" the table creation logic fails with duckdb error Error: Parser Error: syntax error at or near "1"

Proposed changes

Add quotes around database and schema names to allow for numerical prefixed database/schemas

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Without quotes, duckdb complains about table creation for database/schema names starting with a number. Say an uuid.
@JichaoS
Copy link
Contributor Author

JichaoS commented Feb 1, 2024

Pretty simple change. I can add test too if you'd like.

@jwills
Copy link
Owner

jwills commented Feb 1, 2024

looks fine, just going to make sure tests pass

@jwills
Copy link
Owner

jwills commented Feb 1, 2024

ugh, lots of motherduck failures cause of the stupid secrets issue; there must be a way to fix this but for the time being i will just run this locally

@jwills jwills merged commit 0e270b7 into jwills:main Feb 1, 2024
1 check failed
@jwills
Copy link
Owner

jwills commented Feb 1, 2024

Everything ran perfectly locally-- thank you @JichaoS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants