Skip to content

Commit

Permalink
Allow the rustfmt step to fail
Browse files Browse the repository at this point in the history
The weekly openapi job can remove files when their surface shrinks
leading to a broken pipeline. This allows that failing step to
pass, which in turn pushes up a broken and unformatted PR in that case.
Since we have to fix API breakages anyways, that is reasonable.
  • Loading branch information
arlyon committed Nov 18, 2022
1 parent 483161f commit df4b88d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ args = ["-a", "--delete-during", "out/", "../src/resources/generated"]
command = "cargo"
toolchain = "nightly"
install_crate = "rustfmt"
# we set this to true because missing files currently cause rustfmt to fail
# which impacts our weekly CI job
ignore_errors = true
args = ["fmt"]

[tasks.check]
Expand Down

0 comments on commit df4b88d

Please sign in to comment.