Skip to content

Commit

Permalink
Use CGO_ENABLED=1 when building natively on darwin
Browse files Browse the repository at this point in the history
Need to use CGO for mDNS resolution, but cross builds need CGO disabled
See golang/go#12524 for details

Note: Homebrew forumla will need to be updated to pick up this change

Fixes containers#10737

Signed-off-by: Jhon Honce <[email protected]>
  • Loading branch information
jwhonce committed Oct 14, 2021
1 parent ac73303 commit ab4c9a8
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,15 @@ define go-get
$(GO) get -u ${1}
endef

# Need to use CGO for mDNS resolution, but cross builds need CGO disabled
# See https://github.com/golang/go/issues/12524 for details
DARWIN_GCO := 0
ifeq ($(NATIVE_GOOS),darwin)
ifdef HOMEBREW_PREFIX
DARWIN_GCO := 1
endif
endif

###
### Primary entry-point targets
###
Expand Down Expand Up @@ -351,7 +360,7 @@ podman-remote-windows: ## Build podman-remote for Windows
.PHONY: podman-remote-darwin
podman-remote-darwin: ## Build podman-remote for macOS
$(MAKE) \
CGO_ENABLED=0 \
CGO_ENABLED=$(DARWIN_GCO) \
GOOS=darwin \
GOARCH=$(GOARCH) \
bin/darwin/podman
Expand Down

0 comments on commit ab4c9a8

Please sign in to comment.