Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few situations, we need to override the return type of a method:
In previous Java-GI versions, the return type would be updated with a patch, but that would also impact the actual call to the native function. That can lead to segfaults. So with this PR, the return type of the Java bindings is changed, but the native function invocation still uses the type signature as declared in the GIR file.
The following return types are changed:
void GtkMediaStream.play()
returns void, but a virtual method with the same name returnsgboolean
. The instance method now also returnsgboolean
(alwaystrue
).void GstAudioSink.stop()
overridesgboolean GstBaseSink.stop()
, so it now returnsgboolean
(alwaystrue
).void GstVideoOverlay.setRenderRectangle()
returns void, but a virtual method with the same name returnsgboolean
. The instance method now also returnsgboolean
(alwaystrue
).void SoupAuthDomain.challenge()
returns void, but a virtual method with the same name returnschar*
. The instance method now also returnschar*
(alwaysnull
).