Callbacks improved #25

jwharm · 2022-12-23T22:08:47Z

Moved most of the callback code into a new type Closure, which Signal now also implements so they both use the same code.
Removed the user_data parameters from the Java API. They have no purpose in language bindings.
Removed the source parameter in signal handlers. I think it is not necessary. It also doesn't exist in the GIR files, only in the header files.
Completely reworked the code generation of parameters (in the Variable class) because it was slowly becoming a mess. It is hopefully a bit more logical now.
Added generation of callbacks with out-parameters.

Some of these changes (the removal of the signal source parameter, and the user_data parameter) breaks API so if you have any objections I will rethink this.

# Conflicts: # generator/src/main/java/io/github/jwharm/javagi/model/Alias.java # generator/src/main/java/io/github/jwharm/javagi/model/Callback.java # generator/src/main/java/io/github/jwharm/javagi/model/Parameters.java # generator/src/main/java/io/github/jwharm/javagi/model/RegisteredType.java # generator/src/main/java/io/github/jwharm/javagi/model/Union.java # glib/src/main/java/io/github/jwharm/javagi/Interop.java # glib/src/main/java/io/github/jwharm/javagi/ObjectBase.java # glib/src/main/java/io/github/jwharm/javagi/Signal.java

…nal source parameter

JFronny

I agree that the removed parameters don't make sense in an environment like java where their value is usually already available implicitly.

example/src/main/java/io/github/jwharm/javagi/example/Gtk4Example.java

generator/src/main/java/io/github/jwharm/javagi/model/Variable.java

jwharm and others added 22 commits December 9, 2022 20:17

Added marshal functions (work in progress)

41b6440

Work in progress on callbacks

05e735a

Added dependency on asm

d11f5b2

Bytecode generation (work in progress)

b229878

Bytecode generation (more work in progress)

f149dc9

Bytecode generation (more work in progress)

3de0bd2

ASM-less callbacks

ed99868

Insert instance

841b8d5

Quick demo

12af622

Use bindTo

3cf6a0f

Don't get FunctionDescriptor/MethodHandle multiple times

9be1564

Clean up example

0042052

Merge pull request #23 from jwharm/callbacks-without-asm

6400d3d

Merge remote-tracking branch 'origin/main' into callbacks

ff8429a

Type checked fromAddress

5b72700

Null check in marshal

4782241

Simplify CallableType.isSafeToBind

1fb6584

upcall cannot be private; removed asm dependency

ec842f4

upcall cannot be private; removed asm dependency

ab67e5c

Reworked parameter handling, removed user_data parameter, removed sig…

c1a6a10

…nal source parameter

Generate signals and callbacks with out-parameters

db421bb

jwharm requested a review from JFronny December 23, 2022 22:08

JFronny suggested changes Dec 25, 2022

View reviewed changes

example/src/main/java/io/github/jwharm/javagi/example/Gtk4Example.java Outdated Show resolved Hide resolved

generator/src/main/java/io/github/jwharm/javagi/model/Variable.java Show resolved Hide resolved

jwharm added 4 commits December 28, 2022 16:43

Fix Gtk4Example, remove null annotation on void type

3b14f7f

Explicitly set toolchain language version to 19

bc2e40e

Jetbrains Annotations is not a runtime dependency

5953f9b

Change module dependency on org.glib to transitive

0cdc439

jwharm merged commit eeb2e91 into main Dec 28, 2022

jwharm deleted the callbacks_improved branch December 28, 2022 15:53

This was referenced Dec 30, 2022

Function pointers (callbacks, signals and virtual functions) depend on a data parameter #15

Closed

Out-parameter arrays with unknown length are not generated #13

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Callbacks improved #25

Callbacks improved #25

jwharm commented Dec 23, 2022

JFronny left a comment

Callbacks improved #25

Callbacks improved #25

Conversation

jwharm commented Dec 23, 2022

JFronny left a comment

Choose a reason for hiding this comment