Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mutable lists #171

Merged
merged 4 commits into from
Dec 29, 2024
Merged

Add support for mutable lists #171

merged 4 commits into from
Dec 29, 2024

Conversation

JFronny
Copy link
Contributor

@JFronny JFronny commented Dec 27, 2024

Some lists in GTK support mutation via append, remove and splice.
This implements the required methods to allow mutation on them.
Additionally, this allows patches to pick implementation classes for generics where appropriate (like StringObject for StringList as its documentation suggests)

@jwharm
Copy link
Owner

jwharm commented Dec 27, 2024

Thank you, this looks really promising!

@jwharm
Copy link
Owner

jwharm commented Dec 29, 2024

Looking good, I will merge this.
Do you mind if I add copyright notices to the new files?

When I have some more time, I will probably change the new java-gi-to-string attribute a bit, so I can use it instead of the custom generated toString methods on GValue, GType and GVariant.

@jwharm jwharm merged commit 41cf14d into jwharm:main Dec 29, 2024
@JFronny
Copy link
Contributor Author

JFronny commented Dec 29, 2024

Do you mind if I add copyright notices to the new files?

I do not mind, feel free to add them.

I will probably change the new java-gi-to-string attribute a bit

I have actually experimented with that a bit, you can find my results here

@JFronny JFronny deleted the mutable-lists branch December 29, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants