Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change trailing flag parameters into varargs #140

Closed
jwharm opened this issue Sep 27, 2024 · 0 comments
Closed

Change trailing flag parameters into varargs #140

jwharm opened this issue Sep 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jwharm
Copy link
Owner

jwharm commented Sep 27, 2024

In Java-GI 0.10.0, all flag parameters were changed from int to Set<FlagType>. All methods with these parameters were overloaded to accept a single FlagType parameter too. It would be even better to turn trailing flag parameters into variadic (FlagType...) arguments. Other flag parameters and return types should still be Set<FlagType>, probably with the overloads still available.
@jwharm jwharm added the enhancement New feature or request label Sep 27, 2024
jwharm added a commit that referenced this issue Sep 28, 2024
@jwharm
Set trailing flag parameters as varargs (fixes #140)
f8da5c8
@jwharm jwharm closed this as completed in aa3527b Sep 29, 2024
jwharm added a commit that referenced this issue Oct 6, 2024
@jwharm
Generate variadic setter methods in builder classes for flag properti…
c3825a7 
…es, in addition to the one with a Set<> parameter (related to #140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwharm