Merge pull request #165 from jwharm/auto-properties

Merge branch auto-properties
jwharm · Dec 15, 2024 · ab146be · ab146be
2 parents 3246a26 + eecbc55
commit ab146be
Show file tree

Hide file tree

Showing 8 changed files with 310 additions and 176 deletions.
diff --git a/modules/gio/src/main/java/io/github/jwharm/javagi/gio/ListIndexModel.java b/modules/gio/src/main/java/io/github/jwharm/javagi/gio/ListIndexModel.java
@@ -87,7 +87,7 @@ public void setSize(int size) {
      *
      * @return always returns the value of {@link ListIndex#gtype}
      */
-    @Property(name="item-type", constructOnly = true)
+    @Property(constructOnly = true)
     @Override
     public Type getItemType() {
         return ListIndex.gtype;
@@ -98,7 +98,8 @@ public Type getItemType() {
      *
      * @param itemType ignored
      */
-    @Property(name="item-type")
+    @SuppressWarnings("unused")
+    @Property(constructOnly = true)
     public void setItemType(Type itemType) {
     }
 

diff --git a/modules/gio/src/test/java/io/github/jwharm/javagi/test/gio/ListModelTest.java b/modules/gio/src/test/java/io/github/jwharm/javagi/test/gio/ListModelTest.java
@@ -27,7 +27,7 @@ public void createListModel() {
         assertEquals(listIndexModel.getItemType(), ListIndexModel.ListIndex.getType());
         assertEquals(1000, listIndexModel.getNItems());
 
-        var item500 = (ListIndexModel.ListIndex) listIndexModel.getItem(500);
+        var item500 = listIndexModel.getItem(500);
         assertNotNull(item500);
         assertEquals(500, item500.getIndex());
 

diff --git a/modules/gobject/src/main/java/io/github/jwharm/javagi/gobject/annotations/Property.java b/modules/gobject/src/main/java/io/github/jwharm/javagi/gobject/annotations/Property.java
@@ -1,5 +1,5 @@
 /* Java-GI - Java language bindings for GObject-Introspection-based libraries
- * Copyright (C) 2022-2023 Jan-Willem Harmannij
+ * Copyright (C) 2022-2024 Jan-Willem Harmannij
  *
  * SPDX-License-Identifier: LGPL-2.1-or-later
  *
@@ -26,11 +26,21 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
+/**
+ * The {@code @Property} annotation is used to indicate that a method (or pair
+ * of methods) is a property, to set a property name and flags, or to specify
+ * that a pair of get- and set-methods are not properties (using
+ * {@code skip=false}).
+ * <p>
+ * Always set the {@code @Property} annotation with the same parameters on both
+ * the get- and set-method.
+ */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.METHOD)
 public @interface Property {
     String name() default "";
     Class<? extends ParamSpec> type() default ParamSpec.class;
+    boolean skip() default false;
     boolean readable() default true;
     boolean writable() default true;
     boolean construct() default false;