Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add package_ignore_dependencies option #49

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

betaboon
Copy link
Collaborator

No description provided.

Copy link
Owner

@jvolkman jvolkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is fine. I don't love the proliferation of package_xyz_dependencies attributes we've got going on, but that's the model for now. I don't know of a better user experience; maybe something like package "annotations".

Another thought I had about this particular problem was declaring "package groups" or something - basically one package would contain multiple wheels. But that's a larger change with presumably hairy edge cases.

examples/pdm/example_lock.bzl Outdated Show resolved Hide resolved
pycross/private/tools/bzl_lock_generator.py Outdated Show resolved Hide resolved
@betaboon betaboon force-pushed the ignore-dependencies branch from 3638d0f to 4853921 Compare November 21, 2023 08:30
@betaboon
Copy link
Collaborator Author

Overall I think this is fine. I don't love the proliferation of package_xyz_dependencies attributes we've got going on, but that's the model for now. I don't know of a better user experience; maybe something like package "annotations".

Another thought I had about this particular problem was declaring "package groups" or something - basically one package would contain multiple wheels. But that's a larger change with presumably hairy edge cases.

yes. i think we can do some rework here.

another issue we could address: when package_build_dependencies are defined, but the package goes away (eg because of renovate updating) the whole thing will break.

@betaboon betaboon force-pushed the ignore-dependencies branch from 4853921 to fcc8207 Compare November 21, 2023 16:20
@betaboon betaboon marked this pull request as ready for review November 21, 2023 16:21
@jvolkman jvolkman merged commit a196914 into jvolkman:main Nov 21, 2023
1 check passed
@betaboon betaboon deleted the ignore-dependencies branch November 21, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants