Fix depwarns with current Julia #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current versions of Julia have deprecated the types Uint{8,16} with a
lowercase 'i', in favor of the same type names with an uppercase 'I'.
Current versions of Julia deprecated the use of the "bool" function to convert integer values to boolean type.
Current versions of Julia deprecated the "int" function in favor of "Int".
Current versions of Julia deprecated the [x:y] syntax in favor of collect(x:y).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to run this (awesome) visualization with the latest version
of Julia (0.4.7), and got numerous deprecation warnings, obscuring the
lovely output. This fixes all of those;
julia gzip.jl file.gznowruns without any depwarns.
(I also ended up filing JuliaLang/julia#19686
because julia made it hard to find the source of the deprecation
warnings.)
Thanks for the amazing visualization; I went looking for an inflate
library I could hack to do this exact thing, and found your complete
implementation of exactly what I wanted instead.