Use ConcurrentReferenceHashMap with SOFT references for caches

jvmusin · Mar 18, 2024 · d46335b · d46335b
1 parent 00cc829
commit d46335b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/main/kotlin/io/github/jvmusin/polybacs/polygon/PolygonProblemDownloader.kt b/src/main/kotlin/io/github/jvmusin/polybacs/polygon/PolygonProblemDownloader.kt
@@ -26,7 +26,7 @@ import kotlinx.coroutines.async
 import kotlinx.coroutines.coroutineScope
 import kotlinx.coroutines.withContext
 import org.springframework.stereotype.Component
-import java.util.concurrent.ConcurrentHashMap
+import org.springframework.util.ConcurrentReferenceHashMap
 
 /**
  * Polygon problem downloader
@@ -55,7 +55,7 @@ class PolygonProblemDownloader(
     /**
      * Problems cache.
      */
-    private val cache = ConcurrentHashMap<FullPackageId, IRProblem>()
+    private val cache = ConcurrentReferenceHashMap<FullPackageId, IRProblem>()
 
     /**
      * Returns problem using Polygon API.

diff --git a/src/main/kotlin/io/github/jvmusin/polybacs/polygon/api/PolygonApiExtensions.kt b/src/main/kotlin/io/github/jvmusin/polybacs/polygon/api/PolygonApiExtensions.kt
@@ -5,10 +5,11 @@ import io.github.jvmusin.polybacs.polygon.exception.response.NoSuchProblemExcept
 import kotlinx.coroutines.sync.Mutex
 import kotlinx.coroutines.sync.withLock
 import org.apache.commons.compress.archivers.zip.ZipFile
+import org.springframework.util.ConcurrentReferenceHashMap
 import java.util.concurrent.ConcurrentHashMap
 
-private val packagesCache = ConcurrentHashMap<Int, ByteArray>()
 private val packagesCacheLocks = ConcurrentHashMap<Int, Mutex>()
+private val packagesCache = ConcurrentReferenceHashMap<Int, ByteArray>()
 
 private suspend fun PolygonApi.downloadPackageZip(problemId: Int, packageId: Int): ByteArray {
     return packagesCacheLocks.computeIfAbsent(packageId) { Mutex() }.withLock {