Fix references, rename ref -> reference and remove matchIdx from the AST... #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but @mathiasbynens should review it to. |
|
@D10 thanks for the feedback! |
|
LGTM! |
jviereck
added a commit
that referenced
this pull request
Aug 30, 2014
Fix references, rename ref -> reference and remove matchIdx from the AST...
|
Thanks @mathiasbynens for the review! |
|
Please release a new version with this fix so that regjsgen can be updated too. Thanks! |
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.... Closes #57
This turned out to be a regression from my commit 278aabb:
This PR:
ref→referencein the ASTmatchIdxfrom the AST for capture groupsThe reason to remove the
matchIdxis the same as forlastMatchIdx. ThematchIdxcan be seen as a "state" variable, that can be computed easily when walking over the tree if needed.@mathiasbynens, @D10, can someone of you maybe review the patch? What do you think about point 3)?