[FEATURE] Include hooks in time measurement of blocks #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you paste an example output here? Thanks! |
|
joluj
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Nice work 🎉
I just spent too much time on figuring out the performance differences between hrtime.bigint(), Date.now(), and new Date().getTime just to figure out that there is not really a difference for our use case. The only reason why we'd want to switch to hrtime.bigint() would be a more accurate time measurements (nanoseconds instead of milliseconds), but milliseconds is enough since Jayvee is not fast enough anyway.
If you are interested, here is the test code:
import { hrtime } from 'node:process';
const num_loops = 1;
let start = hrtime.bigint();
for (let i = 0; i < num_loops; i++) {
// do nothing
const x = hrtime.bigint() / 1000_000n;
const y = hrtime.bigint() / 1000_000n;
}
let end = hrtime.bigint();
console.log(`hrtime.bigint() took ${(end - start) / 1000_000n}ms (${(end - start) / 1_000n}µs)`);
start = hrtime.bigint();
for (let i = 0; i < num_loops; i++) {
const x = Date.now();
const y = Date.now();
}
end = hrtime.bigint();
console.log(`Date.now() took ${(end - start) / 1000_000n}ms (${(end - start) / 1_000n}µs)`);
start = hrtime.bigint();
for (let i = 0; i < num_loops; i++) {
const x = new Date().getTime();
const y = new Date().getTime();
}
end = hrtime.bigint();
console.log(`new Date().getTime() took ${(end - start) / 1000_000n}ms (${(end - start) / 1_000n}µs)`);Thank you for listening to my TED talk, we can merge this how it is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #637.
This PR adds the hook duration to the debug logger. This is the same level as block duration logging.