Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check windows path issues in CI #499

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Check windows path issues in CI #499

merged 4 commits into from
Jan 11, 2024

Conversation

joluj
Copy link
Contributor

@joluj joluj commented Jan 11, 2024

See #494.

Asserts that there a now invalid file names for Windows (see https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file)

@joluj
Copy link
Contributor Author

joluj commented Jan 11, 2024

It fails on 0b1d092 (at a stage where there are invalid file names). That's expected 🎉

@joluj joluj requested a review from georg-schwarz January 11, 2024 13:40
@joluj
Copy link
Contributor Author

joluj commented Jan 11, 2024

@OmarFourati FYI

@joluj joluj merged commit cc8c26c into main Jan 11, 2024
3 checks passed
@joluj joluj deleted the #494_windows_path_issues branch January 11, 2024 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants