Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different method for retrieving process path. #47

Merged
merged 1 commit into from
Jul 30, 2017
Merged

Conversation

horsenit
Copy link
Contributor

@horsenit horsenit commented Jul 30, 2017

Previous method occasionally breaks completely (PUBG, process path returned is null)
And will also ocassionally get capitalization wrong, breaking process name matching (could/should make this case insensitive anyways?) (Hitman 2016, should be HITMAN.exe, but returns hitman.exe)

This is on latest Windows 10, by the way.

Previous method occasionally breaks completely (PUBG, process path returned is null)
And will also ocassionally get capitalization wrong, breaking process name matching (could/should make this case insensitive anyways?) (Hitman 2016, should be HITMAN.exe, but returns hitman.exe)
@juv
Copy link
Owner

juv commented Jul 30, 2017

Does vibranceGUI work with PUBG in this commit?

@juv
Copy link
Owner

juv commented Jul 30, 2017

What about x64 processes? Remember: vibranceGUI is running as a x86 executable, which might cause conflicts.

@horsenit
Copy link
Contributor Author

Yes, this works with PUBG now (it worked before with manually finding the executable, but this allows the process list to work correctly.) PUBG, and Hitman are x64 processes, so it does work correctly with them.

@juv juv merged commit a527f0d into juv:master Jul 30, 2017
@juv
Copy link
Owner

juv commented Jul 30, 2017

Good catch, thanks

@juv
Copy link
Owner

juv commented Jul 30, 2017

Oh it looks like there are some incompatibilities though?
https://technet.microsoft.com/de-de/library/ms683198.aspx (in the comments).

@horsenit
Copy link
Contributor Author

Oh, sorry. Maybe this is something that was changed in later versions of Windows? I don't have anything running an earlier version to readily check.

@horsenit
Copy link
Contributor Author

I believe QueryFullProcessImageName should work for retrieving the process name from x86, however it's only available from Vista onwards if that's a concern.

Sorry about this.

@juv
Copy link
Owner

juv commented Jul 30, 2017

Can you try if this executable works for you (finding PUBG and other x64 programs?)

vibrance.GUI.exe.zip

@horsenit
Copy link
Contributor Author

Yes, it does work correctly for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants